Skip to content

HTTPPlugin : Add a builder option to provide custom server (enables providing options like ssl etc) #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 4, 2025
Merged

HTTPPlugin : Add a builder option to provide custom server (enables providing options like ssl etc) #185

merged 6 commits into from
Nov 4, 2025

Conversation

@MehakBindra
Copy link
Contributor

@MehakBindra MehakBindra commented Oct 23, 2025 •
edited
Loading

Tested with code like (check running on and activities received on port 8000 )

def make_server(app: FastAPI) -> uvicorn.Server:
    config = uvicorn.Config(
        app=app,
        host="0.0.0.0",
        port=8000,
        log_level="debug",
    )
    return uvicorn.Server(config)


app = App(
    plugins=[
        DevToolsPlugin(),
        HttpPlugin(app_id=None, server_factory=make_server),
    ]
)

Copilot AI review requested due to automatic review settings October 23, 2025 22:05
Copilot AI reviewed Oct 23, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for custom server configuration in the HTTPPlugin by introducing a server_factory parameter. This enables users to provide their own pre-configured uvicorn server with custom options like SSL certificates, custom logging, or other server-level configurations.

Key Changes:

  • Added optional server_factory parameter to HTTPPlugin constructor
  • Modified startup logic to use custom server when provided, with port conflict detection
  • Added documentation for the new parameter

MehakBindra and others added 2 commits October 23, 2025 15:07
@MehakBindra
Update packages/apps/src/microsoft/teams/apps/http_plugin.py
488db0e 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
long line
0389157
lilyydu
lilyydu reviewed Oct 23, 2025
View reviewed changes
heyitsaamir
heyitsaamir approved these changes Nov 4, 2025
View reviewed changes
Copy link
Collaborator

@heyitsaamir heyitsaamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked offline. This makes sense to me. Add the code comment and 🚢

@MehakBindra MehakBindra merged commit 564fa26 into main Nov 4, 2025
7 checks passed
@MehakBindra MehakBindra deleted the mehak/server branch November 4, 2025 19:56
@heyitsaamir heyitsaamir mentioned this pull request Nov 10, 2025
Merged
heyitsaamir added a commit that referenced this pull request Nov 10, 2025
@heyitsaamir
Release version 2.0.0a5 (#208)
4454bac 
- Remove support for 3.14 (#207)
  - Add Federated Identity Credentials support (#203)
  - Add User Managed Identity support via MSAL (#192)
  - Introduce msal (#191)
  - Populate empty package READMEs with usage examples (#196)
  - Rename Teams AI to Teams SDK 🎉  (#201)
- HTTPPlugin : Add a builder option to provide custom server (enables
providing options like ssl etc) (#185)
  - get type hint of class, not object (#202)
  - Temporary: skip streaming tests  (#200)
  - Fix workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lilyydu lilyydu lilyydu left review comments

Copilot code review Copilot Copilot left review comments

@heyitsaamir heyitsaamir heyitsaamir approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MehakBindra @heyitsaamir @lilyydu